Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PcpNodeRef::GetUniqueIdentifier is missing PCP_API, but referenced from public header #704

Closed
jcowles opened this issue Nov 24, 2018 · 1 comment
Closed

PcpNodeRef::GetUniqueIdentifier is missing PCP_API, but referenced from public header #704

jcowles opened this issue Nov 24, 2018 · 1 comment

Comments

@jcowles
Copy link

jcowles commented Nov 24, 2018 •
edited
Loading

Description of Issue

Missing PCP_API:
https://github.com/PixarAnimationStudios/USD/blob/56c2e1def36ee07121f4ecb349c1626472b3c338/pxr/usd/lib/pcp/node.h#L105

And in-lined here:
https://github.com/PixarAnimationStudios/USD/blob/56c2e1def36ee07121f4ecb349c1626472b3c338/pxr/usd/lib/pcp/node.h#L98

Which means anything including node.h can't compile

Steps to Reproduce

  1. Include node.h from an external application.

System Information (OS, Hardware)

Windows 10

Package Versions

USD 18.11

Build Flags

--build-monolithic
@jcowles jcowles changed the title PcpNodeRef::GetUniqueIdentifier is missing API guard, but referenced from public header PcpNodeRef::GetUniqueIdentifier is missing PCP_API, but referenced from public header Nov 25, 2018
@jtran56
Copy link

jtran56 commented Nov 28, 2018

Filed as internal issue #USD-4941.

AdamFelt pushed a commit to autodesk-forks/USD that referenced this issue Apr 16, 2024
@zhangha182
Merge pull request PixarAnimationStudios#704 from autodesk-forks/reso…
0c6ff40 
…lve/adsk/internal-only/feature/pipeline_adsk

Refine Pipeline For Test Stage and SkipList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcowles @sunyab @jtran56