[usdview] Fix _reopenStage for cases when launched with --norender #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-6040 |
pixar-oss
pushed a commit
that referenced
this pull request
May 15, 2020
Moved where we set and reset stageView updates during a stage reopen to be safer in the face of exceptions that might get thrown. Fixes #1192 (Internal change: 2068298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Guard
self._stageViewusage and remove redundant_stepSizeChangedcall.Fixes Issue(s)
Triggering a stage reload from usdview without an active renderer will currently fail.