Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clips template asset path support sdf file format arguments #1450

Merged

Conversation

ainaerco
Copy link
Contributor

@ainaerco ainaerco commented Feb 11, 2021

Description of Change(s)

Clips template asset paths support sdf file format arguments.
Discussion is here:
https://groups.google.com/g/usd-interest/c/7SxzTgBVfv4

Fixes Issue(s)

  • Unable to provide file format arguments when clips with template filename are used.

@ainaerco ainaerco force-pushed the feature/ClipsTemplateArgs branch from 96065e2 to 4a07b7e Compare February 11, 2021 18:27
@jilliene
Copy link

Filed as internal issue #USD-6571

@tallytalwar
Copy link
Contributor

Hello @ainaerco

Thanks for filing the PR. The test you added is failing in all our internal testing platforms and configurations. Will it be possible for you to address the failing test?

318: Traceback (most recent call last):
318:   File "/data/jenkins/workspace/LINUX_GAUNTLET/install/tests/testUsdValueClips", line 2359, in test_TemplateFileFormatArguments
318:     self.CheckValue(attr, time=1, expected=Vt.Vec3fArray(2, (1,1,1)))
318:   File "/data/jenkins/workspace/LINUX_GAUNTLET/install/tests/testUsdValueClips", line 133, in CheckValue
318:     self.assertEqual(attr.Get(time), expected)
318: AssertionError: None != Vt.Vec3fArray(2, (Gf.Vec3f(1.0, 1.0, 1.0), Gf.Vec3f(1.0, 1.0, 1.0)))

Thanks

@ainaerco ainaerco force-pushed the feature/ClipsTemplateArgs branch from 4a07b7e to 30ccd87 Compare February 26, 2021 11:05
@ainaerco
Copy link
Contributor Author

Hello @ainaerco

Thanks for filing the PR. The test you added is failing in all our internal testing platforms and configurations. Will it be possible for you to address the failing test?

318: Traceback (most recent call last):
318:   File "/data/jenkins/workspace/LINUX_GAUNTLET/install/tests/testUsdValueClips", line 2359, in test_TemplateFileFormatArguments
318:     self.CheckValue(attr, time=1, expected=Vt.Vec3fArray(2, (1,1,1)))
318:   File "/data/jenkins/workspace/LINUX_GAUNTLET/install/tests/testUsdValueClips", line 133, in CheckValue
318:     self.assertEqual(attr.Get(time), expected)
318: AssertionError: None != Vt.Vec3fArray(2, (Gf.Vec3f(1.0, 1.0, 1.0), Gf.Vec3f(1.0, 1.0, 1.0)))

Thanks

Sorry, I was testing in usd 19.11.

@tallytalwar tallytalwar added the blocked Issue fix or pull request blocked until questions are answered or pending notes are addressed label Feb 26, 2021
@ainaerco
Copy link
Contributor Author

Hello, is there anything else I can do to get this merged?

@c64kernal
Copy link
Contributor

Hi @ainaerco -- the test you added fails for us as @tallytalwar mentioned. Does it pass for you when using the dev branch? 19.11 is quite old and lots of things may have changed.

@ainaerco
Copy link
Contributor Author

I have pushed commit after it was reported that it was failing. Is it failing still?

@tallytalwar
Copy link
Contributor

Hi @ainaerco

Thanks for your patience. The test you are adding is still failing for us:

Traceback (most recent call last):
  File "../testUsdValueClips.py", line 2359, in test_TemplateFileFormatArguments
    self.CheckValue(attr, time=1, expected=Vt.Vec3fArray(2, (1,1,1)))
  File "../testUsdValueClips.py", line 133, in CheckValue
    self.assertEqual(attr.Get(time), expected)
AssertionError: None != Vt.Vec3fArray(2, (Gf.Vec3f(1.0, 1.0, 1.0), Gf.Vec3f(1.0, 1.0, 1.0)))

I also noticed that there is no difference between your previous commit: 4a07b7e and your forced push commit: 30ccd87.

Can you please try running the test on your end and update this PR with a fix?
Thanks

@ainaerco ainaerco force-pushed the feature/ClipsTemplateArgs branch from 30ccd87 to 63e9718 Compare March 24, 2021 10:57
@ainaerco
Copy link
Contributor Author

I think I fixed it now, thanks for checking

@c64kernal c64kernal added pending push and removed blocked Issue fix or pull request blocked until questions are answered or pending notes are addressed labels Mar 29, 2021
@pixar-oss pixar-oss merged commit 373acc2 into PixarAnimationStudios:dev Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants