Fix for resolving symlinks on Windows from multiple processes simultaneously #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Windows symlink location at the same time. The file handle was being created without any sharing flag. And although we keep the file open only very briefly, this could still disrupt another process from reading the same symlink at the same time.
|
Filed as internal issue #USD-6588 |
marktucker
added a commit
to sideeffects/USD
that referenced
this pull request
Mar 12, 2022
…rAnimationStudios#1580 (presumably by accident). Add a FILE_SHARE_READ flag to the CreateFile call that is used to open a symlink location on Windows. This failure was manifesting as a rare intermittent failure to properly resolve a file path inside a symlinked directory on Windows when running many simultaneous processes reading and writing USD files inside this symlinked directory.
marktucker
added a commit
to sideeffects/USD
that referenced
this pull request
Mar 12, 2022
…rAnimationStudios#1580 (presumably by accident). Add a FILE_SHARE_READ flag to the CreateFile call that is used to open a symlink location on Windows. This failure was manifesting as a rare intermittent failure to properly resolve a file path inside a symlinked directory on Windows when running many simultaneous processes reading and writing USD files inside this symlinked directory.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix issue where two threads or processes may try to read a Windows
symlink location at the same time. The file handle was being created without
any sharing flag. And although we keep the file open only very briefly, this
could still disrupt another process from reading the same symlink at the
same time.
Description of Change(s)
Add a FILE_SHARE_READ flag to the CreateFile call that is used to open a symlink location on Windows. This failure was manifesting as a rare intermittent failure to properly resolve a file path inside a symlinked directory on Windows when running many simultaneous processes reading and writing USD files inside this symlinked directory.