usdview - Don't error or warn in Rollover Prim Info if assetInfo has no identifier entry #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ablev-dwa ! Would you consider updating that function's comment about what the (now acceptable) fallback behavior is when there is no identifier-bearing layer to find? |
|
Absolutely, sorry, I should have thought of that. I will update the PR tonight. |
Signed-off-by: Alan Blevins <alan.blevins@dreamworks.com>
ablev-dwa
force-pushed
the
usdview_no_assetInfo_identifier
branch
from
6406fb3 to
8438caf
Compare
|
Updated the docstring for GetAssetCreationTime() |
|
Thanks, @ablev-dwa - looks great! Of course, this function is not Ar 2.0 and non-file-backed-asset friendly at all. But Ar won't give you concrete time/date information, which is why I wrote the function this way in the first place... |
|
That makes sense. We haven't started our journey to Ar2 yet but it will probably be good to start thinking about it :) |
|
Filed as internal issue #USD-6613 |
pixar-oss
added a commit
that referenced
this pull request
Apr 14, 2021
usdview - Don't error or warn in Rollover Prim Info if assetInfo has no identifier entry (Internal change: 2159197)
|
This was merged with commit: e7e6067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Changes usdview's Rollover Prim Info mode to gracefully handle cases where the "identifier" assetInfo is not authored on a prim. The existing code expects the data to exist, and will flood the terminal with KeyErrors if it's not actually authored, which also causes the rollover to be incomplete.
This change will make it Rollover Prim Info faster and more useful in pipelines that do not author the identifier assetInfo metadata.