Support for Python 3.8+ on Windows #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-6682 |
sunyab
requested changes
May 11, 2021
|
I think I addressed all the review notes. Let me know if I missed anything. Would you prefer I rebase this so it's just one change, or is it better to keep the commit history? Let me know which you'd prefer, then I'll rebase the two followup changes to pick this up, and to use the new env var name. |
|
I'd lean towards rebasing it to just one change, thanks! |
Previously this had been disabled because of a change to how the python interpreter searches for DLLs. This change should restore the old behavior, and give software builders the ability to opt into the new python behavior where possible. See https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew
rstelzleni
force-pushed
the
windows-py38-support
branch
from
04e6461 to
2a6c08f
Compare
sunyab
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Previously this had been disabled because of a change to how the python
interpreter searches for DLLs. This change should restore the old
behavior, and give software builders the ability to opt into the new
python behavior where possible. See
https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew
We've discussed a few approaches to this and went with this full path searching approach to try to be as close to the pre python 3.8 behavior as possible. You can disable it with an environment variable, which we'll make use of in the python pypi packages, since those are better off not searching the path.
Fixes Issue(s)