Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not search for the end of the list of children if there are no children #1691

Conversation

williamkrick
Copy link
Contributor

Description of Change(s)

Do not do the O(N) search for the first path that does not have subtree as a prefix if subtree has no children.

Please see #1689 for a detailed description of the problem.

Fixes Issue(s)

@jilliene
Copy link

Filed as internal issue #USD-7037

@sunyab
Copy link
Contributor

sunyab commented Dec 1, 2021

This PR has been merged internally and will be available in the dev branch with the next push.

I wanted to mention that this change was modified to fix a bug where the end iterator was invalid and dereferenced, leading to crashes in certain cases.

@williamkrick
Copy link
Contributor Author

Awesome, thank you so much @sunyab!

@pixar-oss pixar-oss merged commit dd12944 into PixarAnimationStudios:dev Dec 9, 2021
@williamkrick williamkrick deleted the maya/krickw/check_if_the_next_prim_is_not_in_the_subtree_before_starting_the_wider_search branch January 27, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants