usdImagingGL idiff tests should be able to detect the difference between visibly distinct reference images #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed that this covers similar territory as this commit: |
|
Filed as internal issue #USD-7393 |
1 task
wrma6
force-pushed
the
pr/imagediff-detect-reference-diffs
branch
from
3f090c2
to
98174c5
Compare
|
Just poking to see about getting this merged... |
|
@pmolodo , this is in our queue, but our recent focus for 22.08, oss-imaging-wise, has been native silicon build support. |
|
Got it, thanks for the info! |
pixar-oss
pushed a commit
that referenced
this pull request
Jun 7, 2023
This is a follow-up to change 2277652. That change tightened image diff thresholds but were overfitted to internal workstations and caused failures when run on other machines. This change relaxes the thresholds to match values that were used in usdImagingGL tests in change 2245969, which were contributed in PR #1866. Using these values should minimize false negatives on a wider range of machines while still catching major differences. Some baseline images were updated to fall within these new tolerances. (Internal change: 2279351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
With the current parameters used for the image diff tests in usdImagingGL, the reference images cannot be distinguished from each other: idiff passes many image pairs as "similar enough" even though they are (visibly) distinctly different. Specifically, the Fail parameter of 1 (the most lenient value possible) usually passes every image pair, so tests using that rely solely on the additional Perceptual test. Using a Python script, all pairs of images referenced by each test were compared using idiff to determine reasonable Fail and FailPercent parameters. The proposed change would ensure that for the parameters and reference images of each test, the parameters can at least differentiate between any pair of reference images that differ.
Fixes Issue(s)