Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: Fix for crash on loading non-filterable textures #2048

Closed

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Sep 21, 2022

Description of Change(s)

In Metal, several of the texture formats don't support filtering, so the call to generateMipmapsForTexture with fail with an exception on pipeline validation.

Fixes Issue(s)

  • Crashing when loading U16 textures etc.
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7655

@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch 2 times, most recently from d76def6 to a731915 Compare September 30, 2022 19:25
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch 2 times, most recently from a4c615a to e9eae1e Compare November 9, 2022 18:38
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch 2 times, most recently from 0ba95da to fbe323c Compare December 3, 2022 06:58
pixar-oss added a commit that referenced this pull request Jan 27, 2023
APPLE: Fix for crash on loading non-filterable textures

(Internal change: 2259813)
@creijon creijon closed this Jan 30, 2023
@creijon creijon deleted the jon/dev/fix_mipmap_crash branch January 30, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants