[UsdUtils] Add UDIM support for dependencies/usdz and switch material… #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ParamUtils to use shared functions
|
Filed as internal issue #USD-7832 |
|
Hi @lbiasco, just wanted to mention that we iterated on your change internally and wound up with something a bit larger than your PR here. We've committed that separately and will close out this PR when that commit hits the dev branch shortly. Thank you! |
|
Awesome, thank you for the update! |
pixar-oss
pushed a commit
that referenced
this pull request
Apr 3, 2023
and contains the following items: Creates a new UsdShadeUdimUtils class which has methods for working with Udim files. This includes detecting the presence of a UDIM identifier, reoslving UDIM paths, and subsituting indices back into an identifier string. The core logic for these methods was lifted from UsdImaging's materialParamUtils Updates UsdUtils dependencies resolution logic to use these new methods to ensure UDIM tiles are are correctly included as dependencies. Updates UsdImaging's material parsm to make use of this new method As a result of this change, usdUtils now has a dependency on usdShade Thanks to @lbiasco for the foundations of this change! Fixes #2133 (Internal change: 2268797)
|
Closing per previous comment, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ParamUtils to use shared functions
This PR is a continuation of the work from #1477, which is closed since the related accounts are no longer accessible. I tried to vet these changes as much as possible, but I wouldn't be surprised if there are some uses of UDIMs that I missed, so definitely let me know of any uncommon cases to include tests for.
Description of Change(s)
UsdUtilsIsUdimIdentifier,UsdUtilsGetUdimFiles, andUsdUtilsResolveUdimPath. These are also Python-wrapped.