Adds option to euler filter output transform data #299
Conversation
|
Filed as internal issue #152106. |
pmolodo
force-pushed
the
pr/eulerFilter
branch
from
a16637c to
ca3675e
Compare
pmolodo
force-pushed
the
pr/eulerFilter
branch
from
ca3675e to
ce093db
Compare
pmolodo
force-pushed
the
pr/eulerFilter
branch
2 times, most recently
from
708e3bd to
a5b7192
Compare
pmolodo
force-pushed
the
pr/eulerFilter
branch
from
a5b7192 to
6932d3c
Compare
|
pushed new version to fix some merge conflicts |
|
Updated PR to work with the latest usdMaya changes. |
| computeXFormOps(xformSchema, mAnimChanList, usdTime, | ||
| _GetSparseValueWriter()); | ||
| computeXFormOps(xformSchema, mAnimChanList, usdTime, getArgs().eulerFilter, | ||
| previousRotates, _GetSparseValueWriter()); |
There was a problem hiding this comment.
I've resolved the merge conflicts in this PR locally, but my builds are failing because this previousRotates parameter isn't defined in this function. Where should this be coming from?
There was a problem hiding this comment.
This isn't a full code review yet, but I took an initial pass to merge this change in and wasn't able to get it to build due to an issue in the writeTransformAttrs function. I've left a comment for that below.
Also, it would be fantastic if we could have a test for this functionality.
|
Apologies, I thought we had pushed out a recent version that fixed any merge conflicts! Anyway, pushed one now - the source of the "previousRotates" is a data member on the class - it's now been renamed "_previousRotates" to reflect recent naming standardization. I also added some tests, as requested, and a gui checkbox for the file translator options, which I noticed was missing! |
Adds option to euler filter output transform data (Internal change: 1872882)
…lve/dev Regular sync origin/dev to adsk/dev before conflict
Description of Change(s)
Title pretty much says it all... alembic has a similar option, and it's quite handy.
Fixes Issue(s)
Has #287 as a base