Add missing export attributes to SdfLayerDelegate and SdfData #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-4768. |
sunyab
requested changes
Sep 21, 2018
There was a problem hiding this comment.
Hi @sopvop, just had one minor note below.
Also, could you make these changes in the 'dev' branch of the repository? All new development happens there. I think you may need to close this pull request and open a new one with those changes. Thanks!
sunyab
added
the
blocked
sopvop
force-pushed
the
export-sdf-layer-delegate
branch
from
2e31134 to
e27ff96
Compare
|
BTW, recreating pull request was not necessary. You can change target branch if you click edit button to the right of request title. |
sopvop
force-pushed
the
export-sdf-layer-delegate
branch
from
0491f32 to
4b6d8f9
Compare
sunyab
added
pending push
and removed
blocked
sunyab
approved these changes
Oct 17, 2018
pixar-oss
added a commit
that referenced
this pull request
Oct 19, 2018
Add missing export attributes to SdfLayerDelegate and SdfData (Internal change: 1903136)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
Merge pull request PixarAnimationStudios#623 from autodesk-forks/resolve/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Adds export attributes missing from SdlLayerStateDelegate and SdfData. These are necessary to make https://github.com/LumaPictures/usd-qt compile on windows with MSVC
Fixes Issue(s)