Issue #631: fixing vertex attributes on rightHanded meshes when refining for the viewport #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and we had to reveress the winding order (i.e. the USD primitive's orientation attribute is "rightHanded"), we need to reorganize the vertex attribute data whether we are refining for the viewport or not.
|
What if there already is an indirect index array? |
|
I haven't actually tested that case, so I don't know if it works or not. This issue is just about the difference that viewport refinement doesn't work one case where refinement to polygons works. It would be good to know if refinement (to viewport and polygons) works with indirect primvars, but if not I think that warrants a separate issue. |
|
Filed as internal issue #USD-4777. |
pixar-oss
added a commit
that referenced
this pull request
Jan 14, 2019
…tributes Issue #631: fixing vertex attributes on rightHanded meshes when refining for the viewport (Internal change: 1925071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refining a USD mesh packed primitive, if we have vertex attributes
and we had to reveress the winding order (i.e. the USD primitive's
orientation attribute is "rightHanded"), we need to reorganize the
vertex attribute data whether we are refining for the viewport or not.