[usdMaya] fix bogus name clash errors when stripping namespaces #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The way it is implemented will miss error message. Will push update tomorrow. |
When exporter strips namespaces is checks if path was already visited and if so raises an error. However when we also merge transforms and shapes, then it's not an error to map bot of them to same primitive.
|
Now it's ready for review. |
|
Filed as internal issue #USD-4891. |
pixar-oss
added a commit
that referenced
this pull request
Jan 14, 2019
[usdMaya] fix bogus name clash errors when stripping namespaces (Internal change: 1928402)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
### Description of Change(s) Remove the GenericText parameter when create TextRun. And change the parameter of _AccumulateTextRun from CommonTextRun& to CommonTextRunList::iterator. ### Fixes Issue(s) - <!-- Please follow the Contributing and Building guidelines to run tests against your change. Place an X in the box if tests are run and are all tests passing. --> - [ ] I have verified that all unit tests pass with the proposed changes <!-- Place an X in the box if you have submitted a signed Contributor License Agreement. A signed CLA must be received before pull requests can be merged. For instructions, see: http://openusd.org/release/contributing_to_usd.html --> - [ ] I have submitted a signed Contributor License Agreement (cherry picked from commit 9ff3c9984a511e450e54d5062e9c597baad252ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporter strips namespaces is checks if path was already visited and if so raises an error.
However when we also merge transforms and shapes, then it's not an error to map both of them to same primitive.
Description of Change(s)
In addition to checking if path was already visited we check if path is parent or child of visited path.
Fixes Issue(s)
Exporting to usd with namespace stripping and merging transforms and shapes results in error and does not work.