Fix compatibility for AbcCoreOgawa::ReadArchive with Alembic>=1.7.9 #825
Conversation
|
Filed as internal issue #USD-5231 |
| #if ALEMBIC_LIBRARY_VERSION >= 10709 | ||
| TF_DEFINE_ENV_SETTING( | ||
| USD_ABC_READ_ARCHIVE_USE_MMAP, false, | ||
| "Collapse Xforms containing a single geometry into a single geom Prim in USD"); |
There was a problem hiding this comment.
Can you please update the help string?
There was a problem hiding this comment.
Sorry to have let this one slip. Fix is pushed.
| @@ -95,6 +95,12 @@ TF_DEFINE_ENV_SETTING( | |||
| USD_ABC_XFORM_PRIM_COLLAPSE, true, | |||
| "Collapse Xforms containing a single geometry into a single geom Prim in USD"); | |||
|
|
|||
| #if ALEMBIC_LIBRARY_VERSION >= 10709 | |||
There was a problem hiding this comment.
how about updating FindAlembic to generate this automatically?
There was a problem hiding this comment.
What do you mean ?
There was a problem hiding this comment.
Right now we would need to define ALEMBIC_LIBRARY_VERSION manually but the FindAlembic cmake module could have some logic included to set it automatically when it finds the libraries. Just an idea though.
There was a problem hiding this comment.
Unless I'm mistaken ALEMBIC_LIBRARY_VERSION is defined in the Alembic headers.
There was a problem hiding this comment.
Oh, you're right. https://github.com/alembic/alembic/blob/master/lib/Alembic/Util/Config.h.in#L42 perfect :)
…mbic Fix compatibility for AbcCoreOgawa::ReadArchive with Alembic>=1.7.9 (Internal change: 1973396)
Description of Change(s)
Alembic 1.7.9 introduced an API change in
Alembic::AbcCoreOgawa::ReadArchive: a new boolean argument is required. This PR conforms to the new function signature for Alembic >= 1.7.9The behavior of
Alembic::AbcCoreOgawa::ReadArchivecan be configured by a new environment variable:USD_ABC_READ_ARCHIVE_USE_MMAPBy default,
Alembic::AbcCoreOgawa::ReadArchivekeep on using the pre 1.7.9 behaviorFixes Issue(s)