[usdGeom] added support for indexed uint primvar values #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Alex, sorry my other mail didn’t reach you first - we’d prefer not to go
in this direction; we want indices to have a fixed type.
On Fri, May 31, 2019 at 7:10 AM AlexSchwank ***@***.***> wrote:
Description of Change(s)
Added support for indexed primvar values of type uint[].
*testUsdGeomPrimvar.py* could be extended to include a test for this in
*test_PrimvarsAPI()* but not sure if that's necessary.
# make sure UIntArray can be used for indexed primvar values
uint_array = gp_pv.CreatePrimvar('uint_array', Sdf.ValueTypeNames.UIntArray)
uint_values = Vt.UIntArray([3, 1, 4])
uint_array.Set(uint_values)
indices = Vt.IntArray([0, 1, 2, 1, 2, 0])
uint_array.SetIndices(indices)
self.assertFalse(uint_array.ComputeFlattened() is None)
------------------------------
You can view, comment on, or merge this pull request online at:
#861
Commit Summary
- added support for indexed uint primvar values
File Changes
- *M* pxr/usd/lib/usdGeom/primvar.cpp
<https://github.com/PixarAnimationStudios/USD/pull/861/files#diff-0>
(1)
Patch Links:
- https://github.com/PixarAnimationStudios/USD/pull/861.patch
- https://github.com/PixarAnimationStudios/USD/pull/861.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#861>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPOU2DLTJASOBTGNWRFA63PYEWWXANCNFSM4HR3CVOQ>
.
--
--spiffiPhone
|
|
The alembic issues are with the index arrays. But this PR doesn't fix that. It adds support for |
AlexSchwank
changed the title
|
Sorry, @AlexSchwank - I phoned that in without looking at the change. Given that at least Katana pxrUsdIn handles uint primvar arrays (lossily, as it does VtArray...), this change seems fine to me. |
|
No worries, too many similar uint tickets :) |
|
Filed as internal issue #USD-5347 |
pixar-oss
added a commit
that referenced
this pull request
Jun 25, 2019
[usdGeom] added support for indexed uint primvar values (Internal change: 1979080)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Added support for indexed primvar values of type
uint[].testUsdGeomPrimvar.py could be extended to include a test for this in test_PrimvarsAPI() but not sure if that's necessary.