Prevent crashes when calling methods on invalid Usd.SchemaBase objects #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being done in wrapObject. This overloaded __getattribute__ actually allows any of the UsdSchemaBase APIs to be called (as all of the methods at this level can still return useful information). But its purpose is to block calls to APIs defined on subclasses. Provided similar protection for UsdGeomPrimvar, which is an odd case that is like a schema class, but operates on a single attribute and so is not derived from SchemaBase. Added some test cases, including an explicit test of issue PixarAnimationStudios#872, a crash when calling UsdGeom.Xformable().ClearXformOpOrder(). TestUsdRiSplineAPI had to be updated because a test in there was not expecting the RuntimeException from an invalid object.
…ribute is not. More thorough testing of these whitelisted methods. Add a few more SchemaBase tests, including the construction of a CollectionAPI object from an invalid SchemaBase object. The result is an invalid CollectionAPI object.
|
Thanks for the feedback, @spiffmon. Addressing this first round of comments with an additional commit. |
|
Filed as internal issue #USD-5380 |
pixar-oss
added a commit
that referenced
this pull request
Jul 17, 2019
Prevent crashes when calling methods on invalid Usd.SchemaBase objects (Internal change: 1987218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wrapSchemaBase, replace the getattribute method as was already being
done in wrapObject. This overloaded getattribute actually allows any of
the UsdSchemaBase APIs to be called (as all of the methods at this level can
still return useful information). But its purpose is to block calls to APIs
defined on subclasses.
Provided similar protection for UsdGeomPrimvar, which is an odd case that is
like a schema class, but operates on a single attribute and so is not derived
from SchemaBase.
Added some test cases, including an explicit test of issue #872, a crash when
calling UsdGeom.Xformable().ClearXformOpOrder(). TestUsdRiSplineAPI had to be
updated because a test in there was not expecting the RuntimeException from
an invalid object.
Fixes Issue(s)