Dev issue950 #956
Merged
Dev issue950 #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usdMtlx fails to read a mtlx file with more than one bind input PixarAnimationStudios#950
…ge to avoid a build warning..
|
Filed as internal issue #USD-5528 |
|
Thanks for the fix @juliencb2018 -- we'll get this merged in soon. Two small things we changed in reader.cpp is that we kept what look like extraneous parens to avoid some compilers warning about them (it looks like a missed equality check) and then we use the IsEmpty() method on token instead of comparing against an empty string. Thanks again, look for the merge soon! |
|
Great, thanks for letting us know! |
pixar-oss
added a commit
that referenced
this pull request
Sep 20, 2019
Dev issue950 (Internal change: 2004326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
usdMtlx can now properly read a materialX file that has more than one bind input.
Also added debug statements.
Fixes Issue(s)
Issue #950:
usdMtlx fails to read a mtlx file with more than one bind input