Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds USDA_FILESIZE_WARNING setting #980

Conversation

ablev-dwa
Copy link
Contributor

Description of Change(s)

Adds an optional filesize check to textFileFormat that will print a warning if a text layer is loaded that is larger than the specified size in megabytes. This has been really useful for early detection of layers that are accidentally delivered as ascii instead of crate.

The default is 0, which disables the check and maintains the existing behavior of textFileFormat.

Signed-off-by: Alan Blevins <alan.blevins@dreamworks.com>
@jtran56
Copy link

jtran56 commented Sep 23, 2019

Filed as internal issue #USD-5582.

@spiffmon
Copy link
Member

Thanks for this, @ablev-dwa! We’d have made great use of this several times already.

@c64kernal
Copy link
Contributor

Thanks again @ablev-dwa -- this is a great idea. We'll merge it in soon, but I wanted to mention that we had to make a few changes, in particular since this is a lower level library than USD, we had to remove mentions of USD-specific things (e.g., crate) and we changed the env var name to SDF_TEXTFILE_SIZE_WARNING_MB -- I hope that all sounds okay to you. Let us know if you have any feedback on the change once it lands in dev. Thanks again!

@ablev-dwa
Copy link
Contributor Author

we had to remove mentions of USD-specific things (e.g., crate) and we changed the env var name to SDF_TEXTFILE_SIZE_WARNING_MB

Ah, duh, of course 😃 If I would have put a little more thought into it, I would have done the same. All of your changes are fine by me, thanks for sorting it out on your end.

pixar-oss added a commit that referenced this pull request Oct 7, 2019
Adds USDA_FILESIZE_WARNING setting

(Internal change: 2006657)
@pixar-oss pixar-oss merged commit 98ee6dd into PixarAnimationStudios:dev Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants