Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.10 - Implicit on corrupted ring not detected #276

Closed
CptKirk-1701 opened this issue Feb 8, 2022 · 4 comments
Closed

v0.8.10 - Implicit on corrupted ring not detected #276

CptKirk-1701 opened this issue Feb 8, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@CptKirk-1701
Copy link

CptKirk-1701 commented Feb 8, 2022

NOT DETECTED: Grants Level 23 Zealotry Skill (implicit)

Is detected: Grace has 16% increased Aura Effect (implicit)


Item Class: Rings
Rarity: Rare
Chimeric Grip
Ruby Ring
--------
Requirements:
Level: 52
--------
Item Level: 75
--------
Grants Level 23 Zealotry Skill (implicit)
Grace has 16% increased Aura Effect (implicit)
--------
+105 to Evasion Rating
+36 to maximum Energy Shield
+43 to maximum Mana
+27% to Chaos Resistance
--------
Corrupted
@WhiteFang5 WhiteFang5 added the bug Something isn't working label Feb 9, 2022
@WhiteFang5
Copy link
Member

WhiteFang5 commented Feb 9, 2022

I've copied the item details above, and it seems to be working properly in v0.8.10

image

Can you elaborate on what the issue with the stat actually is? It doesn't show up for you, or it can't be searched? or some other issue?

@CptKirk-1701
Copy link
Author

CptKirk-1701 commented Feb 9, 2022

I'm using the 'portable' poe-overlay-0.8.10.exe version, not the installed one. I have the poe-overlay-0.8.10.exe file on my desktop and double-click it to run it. If that makes any difference. I just use all the default settings. The only change I do is open settings, refresh the league and save. (Just a note, if I open settings again the league field is blank again. Does not seem to 'stick' the league setting I saved.)

When I hover over it and press Ctrl-D the Zealotry skill item does not show.

1

2

Found another one. This time the Conductivity skill does not show.

Item Class: Rings
Rarity: Rare
Rapture Whorl
Sapphire Ring
--------
Requirements:
Level: 48
--------
Item Level: 61
--------
Grants Level 23 Conductivity Skill (implicit)
--------
+35 to Dexterity
+27 to Intelligence
Adds 3 to 7 Fire Damage to Attacks
+34 to maximum Energy Shield
12% increased Rarity of Items found
34% increased Elemental Damage with Attack Skills
--------
Corrupted

3

4

I still have both of the rings if you want them to test with.

@WhiteFang5
Copy link
Member

WhiteFang5 commented Feb 10, 2022

Can you post both items copied using CTRL+ALT+C (advanced mod copy)? - Perhaps something is wrong with parsing advanced mods. 🤔

[edit] nvm about the above. I looked through my STD stash tabs and found this things:
image
When using the advanced copy I got this item:

Item Class: Amulets
Rarity: Rare
Loath Rosary
Coral Amulet
--------
Requirements:
Level: 61
--------
Item Level: 80
--------
{ Corruption Implicit Modifier }
Grants Level 23 Malevolence Skill — Unscalable Value (implicit)
--------
{ Prefix Modifier "Vaporous" (Tier: 1) — Defences }
20(33-36)% increased Evasion Rating
{ Prefix Modifier "Dauntless" (Tier: 3) — Defences }
15(14-16)% increased maximum Energy Shield
{ Suffix Modifier "of the Galaxy" (Tier: 4) — Attribute }
+23(21-24) to all Attributes
(Attributes are Strength, Dexterity, and Intelligence)
{ Suffix Modifier "of the Starfish" (Tier: 5) — Life }
Regenerate 10.3(16.1-24) Life per second
--------
Corrupted

When price-checking it, the "Grants Level 23 Malevolence Skill" doesn't show up at all.

Based on what I see in this copy-paste, and my knowledge of how advanced mods are handled, there is indeed an issue with implicits, fractured, enchant and crafting mods in certain cases where the advanced copy text contains ; everything (including the special hyphen) after this is being stripped away, including the (implicit) part, which is actually required to detect the mod properly. I'll look into fixing this for the next release.

@WhiteFang5
Copy link
Member

This issue has been fixed in release v0.8.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants