Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Alert Component Text Prop Code #126

Merged
merged 4 commits into from
Jun 28, 2019
Merged

Remove Alert Component Text Prop Code #126

merged 4 commits into from
Jun 28, 2019

Conversation

michaeljaltamirano
Copy link
Contributor

  1. Removes the deprecation notice from the <Alert /> component (we are no longer using it in the main repo).
  2. Removes the text prop functionality
  3. Removes the test for the text prop functionality

@snags88 snags88 temporarily deployed to curology-radiance-pr-126 June 28, 2019 18:40 Inactive
daigof
daigof approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@daigof daigof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@michaeljaltamirano michaeljaltamirano merged commit 0f0cf0b into master Jun 28, 2019
@michaeljaltamirano michaeljaltamirano deleted the chore/remove-deprecation-notice branch June 28, 2019 19:19
@michaeljaltamirano michaeljaltamirano mentioned this pull request Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daigof daigof daigof approved these changes

@snags88 snags88 Awaiting requested review from snags88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeljaltamirano @daigof @snags88