Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update deprecation notices #127

Merged
merged 3 commits into from
Jun 28, 2019

Conversation

michaeljaltamirano
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano commented Jun 28, 2019

This PR updates our deprecation notices so that our warnings are consistent with our release patterns. This provides us some flexibility for transitioning instead of making a contract for the very next major version.

This is the last PR before I'm going to make a v4 release.

@snags88 snags88 temporarily deployed to curology-radiance-pr-127 June 28, 2019 19:11 Inactive
Copy link
Contributor

@daigof daigof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, better wording now

@michaeljaltamirano michaeljaltamirano merged commit 2488f79 into master Jun 28, 2019
@michaeljaltamirano michaeljaltamirano deleted the chore/update-deprecation-notices branch June 28, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants