[Chore] Downgrade @emotion packages to 10.0.10 or nearest lesser version #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmustin
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression from
@emotion/core10.0.10to10.0.14that is breaking styling in some circumstances where Component A renders a static property of Component B, which we'll call Component C, since it is astyled.div. When Component A passes acssprop to Component C and there are conflicting styles, the precedence of thecssprop is overwritten by the style defined in thestyled.div. This is a change from existing behavior.I have not been able to reproduce it on codesandbox, and have spent much time trying to find the root cause, examining the difference
@emotionpackages, but to no avail. In the meantime this PR will downgrade the packages in a uniform fashion until there is resolution.Note:
@emotion's SemVer got a little out of whack until10.0.14, with more uniformedCHANGELOGs and specified^10.0.14peerDependenciesfor the packages, hence the bump down to10.0.10specifically. In most cases there are either no, or just one or two, versions between10.0.10and10.0.14.