Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerts] Prevent calling exit multiple times #25

Merged
merged 1 commit into from
Nov 28, 2018
Merged

[Alerts] Prevent calling exit multiple times #25

merged 1 commit into from
Nov 28, 2018

Conversation

snags88
Copy link
Contributor

@snags88 snags88 commented Nov 27, 2018

exit function can be called from the duration expiration or onClick of the alert component. This prevents the exit function being called twice if onClick happens immediately right before the duration expires.

@snags88 snags88 self-assigned this Nov 27, 2018
@snags88 snags88 requested a review from mattam November 27, 2018 20:41
mattam
mattam approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@mattam mattam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@snags88 snags88 merged commit 8fbfb97 into master Nov 28, 2018
@snags88 snags88 deleted the fix-alert branch November 28, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattam mattam mattam approved these changes

Assignees

@snags88 snags88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snags88 @mattam