[Chip] Add <Chip /> component, test, and story
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smmullen90
reviewed
Nov 30, 2018
src/shared-components/tag/style.js
Outdated
| const closedStyle = css` | ||
| background-color: ${COLORS.statusGreyBackground}; | ||
| border-color: ${COLORS.statusGreyBorder}; | ||
| span { |
There was a problem hiding this comment.
[note] i think if you rearrange, you can actually interpolate TagText here to make this more specific
There was a problem hiding this comment.
Yup that makes sense. Will update 👍
There was a problem hiding this comment.
@snags88 @smmullen90 I believe we have badge already.
It's this:
It is similar though, wonder if we could have it as two separate types of badges.
I'll throw it up in the slack channel for people to discuss!
|
@smmullen90 I can chat with ben regarding the naming! |
|
Consensus was to go with |
snags88
changed the title
<Tag /> component, test, and story<Chip /> component, test, and story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Chip component to Radiance
Storybook