Checkbox #35
Merged
Checkbox #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snags88
suggested changes
Jan 11, 2019
| @@ -61,14 +61,18 @@ export const Radio = styled.div` | |||
| transition: background-color ${ANIMATION.defaultTiming}; | |||
| width: ${SPACING.medium}; | |||
|
|
|||
| ${({ selector }) => selector === 'checkbox' && css` | |||
There was a problem hiding this comment.
i'd move the other border-radius from L55 next to this so that it's clear it's being overwritten.
Actually probably better practice not to declare the same CSS attribute on the same class so maybe switch it out for a ternary based on the selector
| @@ -23,14 +23,14 @@ export const OuterContainer = styled.div` | |||
|
|
|||
| :focus { | |||
| outline: none; | |||
| ${RadioContainer} { | |||
| ${SelectorContainer} { | |||
There was a problem hiding this comment.
you'll need to change the border-radius here based on the selector type.
|
@snags88 Updated. |
|
@benkolde could you approve from a design stand point for the radio button and check button |
snags88
approved these changes
Jan 11, 2019
docs/checkbox.md
Outdated
| ```jsx | ||
| import { Checkbox } from 'radiance-ui'; | ||
|
|
||
| <Checkbox type='primary' checked> |
There was a problem hiding this comment.
[nit] extra space at the beginning of the line
| const defaultProps = { | ||
| onClick: () => {}, | ||
| type: 'primary', | ||
| selector: "radio", |
There was a problem hiding this comment.
[nit] single quotes over double quotes unless it's a JSX prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the component as is on the master design system sketch file.
Sketch file:
Storybook:
https://curology-radiance-pr-35.herokuapp.com/?selectedKind=Checkbox&selectedStory=Usage&full=0&addons=1&stories=1&panelRight=1&addonPanel=storybooks%2Fstorybook-addon-knobs