Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal gatsby patch #46

Merged
merged 4 commits into from
Jan 29, 2019
Merged

Modal gatsby patch #46

merged 4 commits into from
Jan 29, 2019

Conversation

ZeMunchkin
Copy link
Contributor

@ZeMunchkin ZeMunchkin commented Jan 29, 2019

In this PR

  • move reference to document inside of component to fix gatsby build error

Problem:
Getting build error on Gatsby b/c document is not defined at build-time on Heroku.

screen shot 2019-01-29 at 10 12 19 am

Gatsby docs on issue -- they suggest moving the reference to document to a place that won't be called until document is defined:
https://www.gatsbyjs.org/docs/debugging-html-builds/

To fix this, moved the reference to the document inside the component so that document is defined by the time the reference is made.

@ZeMunchkin ZeMunchkin merged commit ea2b13c into master Jan 29, 2019
@ZeMunchkin ZeMunchkin deleted the modal_gatsby_patch branch January 29, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants