[Emotion v10] Finish upgrading all things to emotion 10 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeMunchkin
reviewed
Feb 7, 2019
| @@ -82,7 +83,7 @@ class Alert extends React.Component { | |||
| > | |||
| <AlertContentContainer> | |||
| <Icon | |||
| css={[alertIconStyles]} | |||
| css={css`${alertIconStyles};`} | |||
There was a problem hiding this comment.
Can you clarify something? alertIconStyles is created in style.js using css. Is there a difference between creating it with css vs wrapping in css here?
There was a problem hiding this comment.
oh nope, there's not. Both ways here are valid. https://emotion.sh/docs/composition
I just did a global search on css= and updated all of it to use the template literal.
| ${selectorIcon}; | ||
| color: ${checked ? COLORS.white : 'transparent'}; |
There was a problem hiding this comment.
🙌 Good refactor on ordering
ZeMunchkin
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following to fully convert to emotion 10
babel-preset-css-propbabel-plugin-emotioncssprop to not use string and align with new usage from emotion 10.jest-emotionconfig in serializer.