Box Shadow Examples #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daigof
commented
Apr 25, 2019
daigof
commented
- It made sense to add this to Constants section like Colors examples
- I also refactored/cleaned up the Colors Story
|
Could we do a similar thing as Colors where we categorize the box shadow examples by context (e.g. legacyColors, brandColors, etc.). I think for box shadows, we have few different ones like Base config, alias config etc |
|
@snags88 yep done |
|
@daigof i'm not seeing the values or the box shadow on the story now: |
|
ughh sorry, fixed |
snags88
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.