Modal global fix #95
Merged
Modal global fix #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I review the code in action (I am refactoring to Radiance modal in PocketDerm)and We need to revert back to its original for regarding Global style to prevent this issue
The way The Radiance Modal is now does not work and do nothing: the style applied to ModalContainer does not reach the .ReactModalPortal element because they are disconnected in runtime (modal is created on the fly below in the dom tree)
According to Emotion docs, the global style injection is harmless and unmounts when the component does so. I tested and the global style does not get injected multiple times when opening the modal more than once so there is no memory leaks: https://emotion.sh/docs/globals