Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also query org.gnome.desktop.interface color-scheme for auto theme #23

Open
kchibisov opened this issue Mar 7, 2023 · 3 comments
Open

Comments

@kchibisov
Copy link
Contributor

Right now the portal is used, but there's also a gnome specific thing https://github.com/GNOME/gsettings-desktop-schemas/blob/98ee09e0a7d1ce99a462eee4c26f51bc497c4d49/schemas/org.gnome.desktop.interface.gschema.xml.in#L297 .

@PolyMeilex
Copy link
Owner

What is the value of using Gnome specific setting if Gnome supports and prefers the existing standard anyway?

We had it implemented already here, but I'm not a huge fan of hard-coding Gnome specific stuff, so it was intentionally replaced with non-gnome specific solution, aka XDG settings portal.

Not opposed to adding it back, I just don't see a point.

@kchibisov
Copy link
Contributor Author

We had it implemented already here, but I'm not a huge fan of hard-coding Gnome specific stuff, so it was intentionally replaced with non-gnome specific solution, aka XDG settings portal.

Mostly as a fallback to portal, I don't have portals at all for example, but have gnome stuff to configure gtk and set preferred theme there. I'm not sure you can be on GNOME without a portal though.

@orowith2os
Copy link

There's no benefit to using GNOME-specific interfaces when cross-desktop standards exist already.

If a desktop doesn't have a portal exposing basic preferences such as these, then imo it's broken.

I'm not sure you can be on GNOME without a portal though.

No, not without a very broken user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants