From 5610eb0f6085b4e1c1ee14a42b8c0d3cd2059ae8 Mon Sep 17 00:00:00 2001 From: Adam Dossa Date: Tue, 22 May 2018 10:22:47 +0100 Subject: [PATCH 1/2] Fixes --- contracts/modules/TransferManager/CountTransferManager.sol | 4 ++-- .../modules/TransferManager/PercentageTransferManager.sol | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contracts/modules/TransferManager/CountTransferManager.sol b/contracts/modules/TransferManager/CountTransferManager.sol index 7e1b7c5b2..0713bbb18 100644 --- a/contracts/modules/TransferManager/CountTransferManager.sol +++ b/contracts/modules/TransferManager/CountTransferManager.sol @@ -15,12 +15,12 @@ contract CountTransferManager is ITransferManager { { } - function verifyTransfer(address _from, address _to, uint256 /* _amount */) public view returns(Result) { + function verifyTransfer(address /* _from */, address _to, uint256 /* _amount */) public view returns(Result) { if (!paused) { if (maxHolderCount < ISecurityToken(securityToken).investorCount()) { // Allow transfers to existing maxHolders if (ISecurityToken(securityToken).balanceOf(_to) != 0) { - return Result.VALID; + return Result.NA; } return Result.INVALID; } diff --git a/contracts/modules/TransferManager/PercentageTransferManager.sol b/contracts/modules/TransferManager/PercentageTransferManager.sol index 36ed53794..94e3f0c91 100644 --- a/contracts/modules/TransferManager/PercentageTransferManager.sol +++ b/contracts/modules/TransferManager/PercentageTransferManager.sol @@ -39,13 +39,13 @@ contract PercentageTransferManager is ITransferManager { if (!paused) { // If an address is on the whitelist, it is allowed to hold more than maxHolderPercentage of the tokens. if (whitelist[_to]) { - return Result.VALID; + return Result.NA; } uint256 newBalance = ISecurityToken(securityToken).balanceOf(_to).add(_amount); if (newBalance.mul(10**18).div(ISecurityToken(securityToken).totalSupply()) > maxHolderPercentage) { return Result.INVALID; } - return Result.VALID; + return Result.NA; } return Result.NA; } From 170692e941e23af22f9f1f74ffa3e3c61d6b10cc Mon Sep 17 00:00:00 2001 From: Adam Dossa Date: Tue, 22 May 2018 10:26:53 +0100 Subject: [PATCH 2/2] Remove unused variable --- contracts/modules/TransferManager/PercentageTransferManager.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/modules/TransferManager/PercentageTransferManager.sol b/contracts/modules/TransferManager/PercentageTransferManager.sol index 94e3f0c91..f2cc70c46 100644 --- a/contracts/modules/TransferManager/PercentageTransferManager.sol +++ b/contracts/modules/TransferManager/PercentageTransferManager.sol @@ -35,7 +35,7 @@ contract PercentageTransferManager is ITransferManager { { } - function verifyTransfer(address _from, address _to, uint256 _amount) public view returns(Result) { + function verifyTransfer(address /* _from */, address _to, uint256 _amount) public view returns(Result) { if (!paused) { // If an address is on the whitelist, it is allowed to hold more than maxHolderPercentage of the tokens. if (whitelist[_to]) {