fix: 🐛 Fix mnemnoic validation bug when given a list #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The validation I introduced prevented a list of mnemonics from being passed in. I fixed the bug + added in tests + github action to run them. |
| @@ -49,8 +49,8 @@ export async function startContainers( | |||
| FAKETIME: `@${timestamp}`, | |||
| CHAIN: chain, | |||
| TOOLING_API_KEY: tooling.apiKey, | |||
| RELAYER_DIDS: dids, | |||
| RELAYER_MNEMONICS: mnemonics, | |||
| RELAYER_DIDS: dids.replace(/, /g, ','), // rest api doesn't tolerate a space after the , | |||
There was a problem hiding this comment.
I think this should also be handled in rest API as well
There was a problem hiding this comment.
Will make a PR there
There was a problem hiding this comment.
upstream PR: PolymeshAssociation/polymesh-rest-api#86
4 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2022
## [3.5.4](v3.5.3...v3.5.4) (2022-02-01) ### Bug Fixes * 🐛 Fix mnemnoic validation bug when given a list ([#29](#29)) ([f478a68](f478a68))
|
🎉 This PR is included in version 3.5.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.