Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rc4] styles getting applied twice #480

Closed
moderndeveloperllc opened this issue Jan 25, 2019 · 1 comment
Closed

[rc4] styles getting applied twice #480

moderndeveloperllc opened this issue Jan 25, 2019 · 1 comment
Assignees
Milestone

Comments

@moderndeveloperllc
Copy link

It appears that styles are getting applied twice in the shadow DOM:

  static get styles() {
    return [
      css`
          .error {
            background: red;
            color: #fff;
          }
          .success {
            background: green;
            color: #fff;
          }
          .warning {
            background: yellow;
            color: #fff;
          }`,
    ];
  }

shows double in Chrome 71 element inspector:

screenshot 2019-01-24 at 6 10 00 pm

Versions

  • lit-element: v2.0.0-rc4
  • webcomponents: v2.2.4
@sorvell
Copy link
Member

sorvell commented Jan 25, 2019

Thanks, we'll get this fixed asap.

@sorvell sorvell self-assigned this Jan 25, 2019
@sorvell sorvell added this to the 2.0.0 milestone Jan 25, 2019
sorvell pushed a commit that referenced this issue Jan 25, 2019
Fixes #480 by refactoring to avoid the typo that was causing styling to be duplicated when an array was returned from `static get styles`.
dfreedm pushed a commit that referenced this issue Jan 25, 2019
Fixes #480 by refactoring to avoid the typo that was causing styling to be duplicated when an array was returned from `static get styles`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants