Removes default for static get styles
#456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #452. In addition... * Fixes type settings so `Array.flat` works. * Optimization: ensures `this.styles` is accessed only once per definition. Since this getter generates CSSResults, it should not be run superfluously.
src/lit-element.ts
Outdated
| @@ -66,14 +66,15 @@ export class LitElement extends UpdatingElement { | |||
| * Array of styles to apply to the element. The styles should be defined | |||
| * using the `css` tag function. | |||
| */ | |||
| static get styles(): CSSResult | CSSResultArray { return []; } | |||
| static styles?: CSSResult | CSSResultArray; | |||
|
|
|||
| private static _styles: CSSResult[]|undefined; | |||
|
|
|||
| private static get _uniqueStyles(): CSSResult[] { | |||
| if (this._styles === undefined) { | |||
There was a problem hiding this comment.
Needs to be hasOwnProperty for subclassing to work.
There was a problem hiding this comment.
Need to use a own property check on styles too
justinfagnani
previously approved these changes
Jan 17, 2019
justinfagnani
requested changes
Jan 17, 2019
src/lit-element.ts
Outdated
| @@ -66,14 +66,15 @@ export class LitElement extends UpdatingElement { | |||
| * Array of styles to apply to the element. The styles should be defined | |||
| * using the `css` tag function. | |||
| */ | |||
| static get styles(): CSSResult | CSSResultArray { return []; } | |||
| static styles?: CSSResult | CSSResultArray; | |||
|
|
|||
| private static _styles: CSSResult[]|undefined; | |||
|
|
|||
| private static get _uniqueStyles(): CSSResult[] { | |||
| if (this._styles === undefined) { | |||
There was a problem hiding this comment.
Need to use a own property check on styles too
src/lit-element.ts
Outdated
| const styles = flattenStyles(this.styles); | ||
| const userStyles = this.styles; | ||
| if (Array.isArray(userStyles)) { | ||
| const styles = flattenStyles(userStyles); |
There was a problem hiding this comment.
Consider not re-flattening if !this.hasOwnProperty('styles')
Also add TODO to cache CSSResults to avoid creating new stylesheet objects for subclasses that spread super.styles into this.styles
justinfagnani
requested changes
Jan 17, 2019
justinfagnani
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452.
In addition...
Array.flatworks.this.stylesis accessed only once per definition. Since this getter generates CSSResults, it should not be run superfluously.