Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of :host and :host() pseudo-classes #458

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Fix documentation of :host and :host() pseudo-classes #458

merged 2 commits into from
Jan 29, 2019

Conversation

djlauk
Copy link
Contributor

@djlauk djlauk commented Jan 18, 2019

I had some trouble getting the attribute hidden to work, because the examples in the docs are faulty.

  • I fixed the code snippets / examples.
  • I changed the explanatory introduction text, to point out that there are two pseudo-classes, how they are different, and which one to use when.

Reference Issue

Fixes part of #353.

@justinfagnani
Copy link
Contributor

Thanks @djlauk!

@justinfagnani justinfagnani merged commit 21b049c into lit:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djlauk @justinfagnani @googlebot