Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds toString to CSSResult #508

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Adds toString to CSSResult #508

merged 1 commit into from
Feb 4, 2019

Conversation

tlouisse
Copy link
Contributor

Reference Issue

Fixes #487

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@justinfagnani
Copy link
Contributor

See my comments on #487. I'm not sure of the utility here.

@justinfagnani justinfagnani merged commit 0008b93 into lit:master Feb 4, 2019
balloob
balloob reviewed Feb 6, 2019
View reviewed changes
src/lib/css-tag.ts
@@ -42,6 +42,10 @@ export class CSSResult {
}
return this._styleSheet;
}

toString(): String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be type string ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. Good catch!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#546

@balloob balloob mentioned this pull request Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@balloob balloob balloob left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlouisse @googlebot @justinfagnani @balloob