Produce nicer error on malformed observer

Polymer · Dec 9, 2015 · 0e248f5 · 0e248f5
1 parent 68707ad
commit 0e248f5
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/standard/effectBuilder.html b/src/standard/effectBuilder.html
@@ -106,6 +106,11 @@
 
     _addComplexObserverEffect: function(observer) {
       var sig = this._parseMethod(observer);
+
+      if (!sig) {
+        throw new Error("Malformed observer expression '" + observer + "'");
+      }
+
       for (var i=0, arg; (i<sig.args.length) && (arg=sig.args[i]); i++) {
         this._addPropertyEffect(arg.model, 'complexObserver', {
           method: sig.method,

diff --git a/test/unit/notify-path.html b/test/unit/notify-path.html
@@ -1044,6 +1044,24 @@
 
 });
 
+suite('malformed observers', function() {
+  test('has nice message on failure', function() {
+    var thrown = false;
+
+    try {
+      Polymer({
+        is: 'x-broken',
+        observers: ['foo(missingParenthesis']
+      });
+    } catch (e) {
+      assert.equal(e.message, "Malformed observer expression 'foo(missingParenthesis'");
+      thrown = true;
+    }
+
+    assert.equal(thrown, true, "No exception thrown when parsing malformed observer");
+  });
+});
+
 </script>
 
 </body>