Lint the tests

Also, fix all the lint errors in the tests
Polymer · Feb 12, 2016 · e5063ca · e5063ca
1 parent a4cc272
commit e5063ca
Show file tree

Hide file tree

Showing 35 changed files with 477 additions and 456 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -1,5 +1,4 @@
 node_modules/*
 bower_components/*
-test/*
 src/**/demo/*
 src/**/experimental/*
diff --git a/gulpfile.js b/gulpfile.js
@@ -127,7 +127,7 @@ gulp.task('release', function(cb) {
 });
 
 gulp.task('lint', function() {
-  return gulp.src('src/**/*.html')
+  return gulp.src(['src/**/*.html', 'test/unit/*.html'])
     .pipe(eslint())
     .pipe(eslint.format())
     .pipe(eslint.failAfterError());

diff --git a/test/.eslintignore b/test/.eslintignore
@@ -0,0 +1,3 @@
+assets/*
+compat/*
+smoke/*
diff --git a/test/.eslintrc.json b/test/.eslintrc.json
@@ -0,0 +1,10 @@
+{
+  "env": {
+    "mocha": true
+  },
+  "globals": {
+    "assert": true,
+    "sinon": true,
+    "WCT": true
+  }
+}
diff --git a/test/unit/array-selector.html b/test/unit/array-selector.html
@@ -32,10 +32,10 @@
 </template>
 
 <script>
+/* global bind observer singleBound multiBound */
 suite('basic', function() {
-
   test('single selection', function() {
-    var el = singleConfigured;
+    var el = document.querySelector('#singleConfigured');
     // Nothing selected
     assert.strictEqual(el.selectedItem, null);
     assert.isFalse(el.isSelected(el.items[0]));
@@ -76,7 +76,7 @@
   });
 
   test('multiple selection', function() {
-    var el = multiConfigured;
+    var el = document.querySelector('#multiConfigured');
     // Nothing selected
     assert.sameMembers(el.selected, []);
     assert.isFalse(el.isSelected(el.items[0]));
@@ -143,7 +143,7 @@
     };
     singleBound.select(bind.items[2]);
     assert.equal(called, true);
-    observer.singleChanged = function(info) {};
+    observer.singleChanged = function() {};
   });
 
   test('single selection sub-property change', function() {
@@ -156,7 +156,7 @@
     };
     bind.set(['items', 2, 'name'], 'test');
     assert.equal(called, true);
-    observer.singleChanged = function(info) {};
+    observer.singleChanged = function() {};
   });
 
   test('single selection sub-property change after unshift', function() {
@@ -170,7 +170,7 @@
     bind.unshift('items', {name: 'zero'});
     bind.set(['items', 3, 'name'], 'test2');
     assert.equal(called, true);
-    observer.singleChanged = function(info) {};
+    observer.singleChanged = function() {};
   });
 
   test('multi selection notification', function() {
@@ -210,7 +210,7 @@
     };
     multiBound.select(bind.items[0]);
     assert.equal(called, true);
-    observer.multiChanged = function(info) {};
+    observer.multiChanged = function() {};
   });
 
   test('multi selection sub-property change', function() {
@@ -230,7 +230,7 @@
     };
     bind.set(['items', 0, 'name'], 'test2');
     assert.equal(called, true);
-    observer.multiChanged = function(info) {};
+    observer.multiChanged = function() {};
   });
 
 

diff --git a/test/unit/async.html b/test/unit/async.html
@@ -19,7 +19,7 @@
 <body>
 
 <script>
-
+/* global Async */
   setup(function() {
     window.Async = Polymer.Async;
   });
@@ -191,7 +191,7 @@
         called3++;
       };
       var h1 = Async.run(callback1);
-      var h2 = Async.run(callback2);
+      var h2 = Async.run(callback2); //eslint-disable-line no-unused-vars
       var h3 = Async.run(callback3);
       Async.cancel(h1);
       Async.cancel(h3);
@@ -306,7 +306,7 @@
         called3++;
       };
       var h1 = Async.run(callback1, 50);
-      var h2 = Async.run(callback2, 50);
+      var h2 = Async.run(callback2, 50); //eslint-disable-line no-unused-vars
       var h3 = Async.run(callback3, 200);
       Async.cancel(h1);
       Async.cancel(h3);

diff --git a/test/unit/attached-style-elements.html b/test/unit/attached-style-elements.html
@@ -1,32 +1,32 @@
-<!--
-@license
-Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
-This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
-The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
-The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
-Code distributed by Google as part of the polymer project is also
-subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
--->
-<dom-module id="attached-style">
-  <style>
-    :host {
-      display: block;
-      box-sizing: border-box;
-      border: 1px solid black;
-      height: 100px;
-    }
-  </style>
-  <template>Hi</template>
-  <script>
-    Polymer({
-
-      is: 'attached-style',
-
-      attached: function() {
-        this.offsetParentAtAttachedTime = this.offsetParent;
-        this.offsetHeightAtAttachedTime = this.offsetHeight;
-      }
-
-    });
-  </script>
-</dom-module>
+<!--
+@license
+Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
+This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
+The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
+The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
+Code distributed by Google as part of the polymer project is also
+subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
+-->
+<dom-module id="attached-style">
+  <style>
+    :host {
+      display: block;
+      box-sizing: border-box;
+      border: 1px solid black;
+      height: 100px;
+    }
+  </style>
+  <template>Hi</template>
+  <script>
+    Polymer({
+
+      is: 'attached-style',
+
+      attached: function() {
+        this.offsetParentAtAttachedTime = this.offsetParent;
+        this.offsetHeightAtAttachedTime = this.offsetHeight;
+      }
+
+    });
+  </script>
+</dom-module>
diff --git a/test/unit/attributes-elements.html b/test/unit/attributes-elements.html
@@ -65,14 +65,14 @@
     propChangedCount: 0,
     attr1ChangedCount: 0,
 
-    propChanged: function(prop) {
+    propChanged: function() {
       this.propChangedCount++;
     },
 
-    attr1Changed: function(prop) {
+    attr1Changed: function() {
       this.attr1ChangedCount++;
     }
-    
+
   });
 </script>
 
@@ -154,4 +154,4 @@
       this.setAttribute('prop2', 'hi');
     }
   });
-</script>
+</script>
diff --git a/test/unit/attributes.html b/test/unit/attributes.html
@@ -55,6 +55,7 @@
 </x-reflect>
 
 <script>
+/* global basicDefault basicConfigured compose reflectDefault reflectConfigured */
 
 var configuredObject = {foo: 'bar', nested: {'meaning': 42}, arr: [0, 'foo', true]};
 var configuredArray = [0, 'foo', true, {foo: 'bar'}];

diff --git a/test/unit/base.html b/test/unit/base.html
@@ -29,6 +29,7 @@
 
 setup(function() {
   // Ensure a clean environment for each test.
+  /* global Base */
   window.Base = Polymer.Base;
   window.Child = Object.create(Base);
   Child._registerFeatures = function() {};

diff --git a/test/unit/behaviors-elements.html b/test/unit/behaviors-elements.html
@@ -90,7 +90,7 @@
 
       overridablePropertyB: {
         value: true
-      },
+      }
 
     },
 
@@ -102,7 +102,7 @@
     _simpleProperty: 'B',
 
     _disabledChanged: function(disabled) {
-      this.__disabled = disabled
+      this.__disabled = disabled;
     },
 
     ready: function() {

diff --git a/test/unit/bind.html b/test/unit/bind.html
@@ -132,7 +132,7 @@
 
   test('NaN does not loop observers', function() {
     el.clearObserverCounts();
-    el.addEventListener('notifierwithoutcomputing-changed', function(e) {
+    el.addEventListener('notifierwithoutcomputing-changed', function() {
       if (el.observerCounts.notifierWithoutComputingChanged >= 3) {
         throw new Error('infinite loop!');
       }
@@ -155,7 +155,7 @@
 
   test('computed property with multiple dependencies', function() {
     var notified = 0;
-    el.addEventListener('computed-from-multiple-values-changed', function(e) {
+    el.addEventListener('computed-from-multiple-values-changed', function() {
       notified++;
     });
     el.sum1 = 10;
@@ -195,7 +195,7 @@
 
   test('no read-only notification sent with assignment', function() {
     var notified = 0;
-    el.addEventListener('readonlyvalue-changed', function(e) {
+    el.addEventListener('readonlyvalue-changed', function() {
       notified++;
     });
     el.readonlyvalue = 47;
@@ -663,7 +663,7 @@
 suite('warnings', function() {
 
   var el;
-  var warn;
+  var warn; //eslint-disable-line no-unused-vars
 
   setup(function() {
     el = document.createElement('x-basic');

diff --git a/test/unit/configure-elements.html b/test/unit/configure-elements.html
@@ -172,7 +172,7 @@
           value: 5
         },
         attrValue: {
-          value: 'attrValue',
+          value: 'attrValue'
         },
         attrNumber: {
           value: '42'
@@ -181,4 +181,4 @@
 
     });
   </script>
-</dom-module>
+</dom-module>