Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event target is incorrect after certain DOM changes in ShadowDOM Polyfill #102

Closed
dfreedm opened this issue Apr 18, 2013 · 6 comments
Closed
Labels

Comments

@dfreedm
Copy link
Member

dfreedm commented Apr 18, 2013

Note: I am unable to reproduce this in a smaller test case

In the youtube sample application, running under ShadowDOM Polyfill, if a video is selected from the list, the upper left button in the video panel does not respond to clicks.

It appears that setting the video title causes the events to no longer have to correct target.
Setting the video title causes MDV to create a text node in the toolbar, which appears to cause the Shadow DOM Polyfill to redistribute nodes incorrectly.

The easiest way to reproduce this is with the following snippet:

$('.title').appendChild(document.createTextNode('event killer'));
@arv
Copy link
Contributor

arv commented Apr 18, 2013

The problem is with e701c2e92632386ccb1a4e886d2884c4e7efa0e2

@dfreedm
Copy link
Member Author

dfreedm commented Apr 18, 2013

That'd be toolkitchen/ShadowDOM@e701c2e

@arv
Copy link
Contributor

arv commented Apr 18, 2013

I'm going to revert that commit and go back to trying to fix the work bench bug in some other way

@dfreedm
Copy link
Member Author

dfreedm commented Apr 18, 2013

Fixed by toolkitchen/ShadowDOM#113

@dfreedm dfreedm closed this as completed Apr 18, 2013
@sorvell sorvell reopened this Apr 22, 2013
@arv
Copy link
Contributor

arv commented Apr 22, 2013

Why reopened? toolkitchen/ShadowDOM@5ccb302 should have fixed this for good.

@sorvell
Copy link
Contributor

sorvell commented Apr 22, 2013

Oops, didn't mean to reopen this.

@sorvell sorvell closed this as completed Apr 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants