Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute value that's a comma delineated list of numbers is converted to a property incorrectly #117

Closed
sorvell opened this issue May 3, 2013 · 1 comment
Assignees

Comments

@sorvell
Copy link
Contributor

sorvell commented May 3, 2013

The attribute value deserializer is incorrectly handling values like this:

value = "10, 20, 30"

parseFloat(value) == 10 and this is not isNaN so it's converted to a number.

Perhaps we could additionally check if parseFloat(value) == value. That check will pass because '10.2' == 10.2

@ghost ghost assigned sjmiles May 3, 2013
@sorvell
Copy link
Contributor Author

sorvell commented May 3, 2013

Same issue with an attribute value like this "48px"

@sjmiles sjmiles closed this as completed May 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants