Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Value of "selected" in the tutorial #1228

Closed
abhiShandy opened this issue Feb 27, 2015 · 5 comments
Closed

Attribute Value of "selected" in the tutorial #1228

abhiShandy opened this issue Feb 27, 2015 · 5 comments

Comments

@abhiShandy
Copy link

Should be "0" instead of "all"
https://www.polymer-project.org/docs/start/tutorial/step-1.html

@Nevraeka
Copy link

Nevraeka commented Mar 2, 2015

I think the attribute valueattr was meant to be used here instead of a selected index.

<paper-tabs id="tabs" valueattr="name" selected="all" self-end>
    <paper-tab name="all">All</paper-tab>
    <paper-tab name="favorites">Favorites</paper-tab>
  </paper-tabs>

@Nevraeka
Copy link

Nevraeka commented Mar 2, 2015

Polymer/old-docs-site#917

This should allow this issue to be closed once this PR is accepted.
cc/ @tjsavage

@robdodson
Copy link
Contributor

ping @arthurevans

@Nevraeka
Copy link

Nevraeka commented Mar 2, 2015

the code is correct as per the docs. We are going to add descriptive text to make the code clearer as @robdodson suggested in the docs PR

@ebidel
Copy link
Contributor

ebidel commented Apr 6, 2015

Cleared up Polymer/old-docs-site@78a0acb

@ebidel ebidel closed this as completed Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants