Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-tap doesn't fire all the time that on-click does #255

Closed
abarth opened this issue Aug 23, 2013 · 5 comments
Closed

on-tap doesn't fire all the time that on-click does #255

abarth opened this issue Aug 23, 2013 · 5 comments
Assignees

Comments

@abarth
Copy link

abarth commented Aug 23, 2013

html```

<script src="../third_party/polymer/polymer.js"></script> Tap me! <script> Polymer('test-view', { onTap: function() { alert('on-tap fired') }, onClick: function() { alert('on-click fired') }, }); </script>

If you follow the instructions in this test case, the on-click event will fire but the on-tap event won't.
@abarth
Copy link
Author

abarth commented Aug 23, 2013

<script src="../third_party/polymer/polymer.js"></script>
<link rel="import" href="../third_party/polymer-all/polymer-ui-elements/polymer-ui-collapsible/polymer-ui-collapsible.html">
<polymer-element name="test-view">
  <template>
    <input style="width: 300px" value="click here, press tab, then press spacebar">
    <button on-tap="onTap" on-click="onClick">Tap me!</button>
  </template>
  <script>
  Polymer('test-view', {
    onTap: function() {
        alert('on-tap fired')
    },
    onClick: function() {
        alert('on-click fired')
    },
  });
  </script>
</polymer-element>
<test-view></test-view>

@ghost ghost assigned dfreedm Aug 23, 2013
@dfreedm
Copy link
Member

dfreedm commented Aug 23, 2013

Yes, this was one of the areas I deprioritized for the tap event. Right now it only listens for pointerevents. I'll make try to make it start supporting more areas that click is fired for.

@dfreedm
Copy link
Member

dfreedm commented Aug 24, 2013

This specific case should be handled in googlearchive/PointerGestures@e237b9f

@abarth
Copy link
Author

abarth commented Aug 24, 2013

Thanks!

@tjsavage
Copy link
Contributor

Closing as it appears to be solved. Please re-open if that's not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants