Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Show Private" to "Show Protected" and never show private members #117

Open
kevinpschaaf opened this issue Apr 24, 2017 · 0 comments

Comments

@kevinpschaaf
Copy link

Description

The "Show Private" checkbox currently seems to toggle methods with _, which generally should be considered protected per internal polymer conventions. Using the new criteria discussed in https://github.com/Polymer/polymer-analyzer/issues/586 (which gives priority to @private/@protected/@public annotations and falls back to inference based on _'s), the toggle should toggle showing protected members (and never show private members).

Additionally, we should consider whether the default should be to show or hide protected members, since e.g. mixins, behaviors, and base classes like Polymer.Element largely consist of protected members for use by subclassers. Perhaps the default for elements could be "Show Protected: unchecked" and for everything else "Show Protected: checked". Seems like it would be nice to sort the members by public/protected as well, but that's maybe more arguable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant