Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm import not working using bundler (parcel) #908

Open
erik-valtechsd opened this issue Mar 18, 2021 · 5 comments
Open

npm import not working using bundler (parcel) #908

erik-valtechsd opened this issue Mar 18, 2021 · 5 comments

Comments

@erik-valtechsd
Copy link

Hello - installing popmotion and bundling using parcel returns "TypeError ... tween is not defined" etc

I tried another bundler and got similar issues. I then installed an older version of popmtion npm i popmotion@8.7.3 and everything works.

I'm on mac 10.15.7

@stokesman
Copy link
Contributor

When installing version 9 into an existing project that's using earlier APIs this would be the expected result. The API has changed almost completely so there is no tween etc.

@erik-valtechsd
Copy link
Author

I was using the quickstart examples but I guess those are deprecated now?

@stokesman
Copy link
Contributor

Yes, I guess they'd be considered deprecated.

While those pages aren't linked to from the homepage, if they are to be kept online it probably should be made more clear they aren't current and the installation section should be updated for installing v8 specifically. Not sure what the library author wants to do there.

@erik-valtechsd
Copy link
Author

The API is linked on the homepage with references to Tween etc. Perhaps a deprecated notice on these pages would avoid confusion.

@stokesman
Copy link
Contributor

stokesman commented Mar 23, 2021

I'd meant they're not linked from the root homepage https://popmotion.io/ but I agree about the deprecation notice. According to #898 (comment) the intention is to add one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants