Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press ESC and F4 to close don't work on any popups launched from another popup #1048

Open
marklchaves opened this issue May 9, 2023 · 0 comments
Labels

Comments

@marklchaves
Copy link
Contributor

Describe the bug

Popup Maker > Popup Settings > Close > Alternate Methods

Press ESC to Close and Press F4 to Close don't work on any popups that are launched from another popup. Only Click Overlay to Close works.

Site information

Popup Maker version: 1.18.1

WordPress version: 6.2

PHP version: X.X.X

Expected behavior

All alternate close methods should work for any popup launched from another popup when the alternate methods settings are on.

Current behavior

See description.

Steps to reproduce

  1. Create a popup that has a click open trigger for another popup.
  2. Added the pum-close and popmake-close classes to the click open trigger so the first popup closes when the second popup opens.
  3. Turn on all Close > Alternate Methods for both popups.
  4. Bring up the first popup and press your ESC key. The first popup closes.
  5. Bring up the first popup again and this time click the trigger in the first popup to display the second popup.
  6. After the second popup displays, press ESC or F4 and the popup will not close as it should. If you click outside the popup content area, the popup will close.

Errors

None

Additional context

Reproduced by a customer and 2 support team members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant