Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP version requirement in readme #1080

Open
jmejmejme opened this issue Oct 2, 2024 · 1 comment
Open

Update PHP version requirement in readme #1080

jmejmejme opened this issue Oct 2, 2024 · 1 comment
Labels

Comments

@jmejmejme
Copy link

Describe the bug

In the readme file and on the wordpress.org plugin page, "Requires PHP: 5.6"

In composer.php:

"config": {
		"platform": {
			"php": "7.4"

Installing the plugin in any PHP version lower than 7.2 results in a critical error printing a message from vendor/composer/platform_check.php

Site information

Popup Maker version: 1.20.2

WordPress version: 6.2

PHP version: <7.2.0

Expected behavior

PHP version requirement in the readme should reflect plugin requirements

Current behavior

PHP version requirement does not reflect actual plugin requirements

Steps to reproduce

  1. Install plugin in a WordPress site running on a PHP version lower than 7.2.0

Additional context

Requiring PHP 7.2 or 7.4 is totally reasonable! Just a nudge to update the readme.

@danieliser
Copy link
Member

How exactly are you installing the plugin? These checks are not run normal installation methods, so I'm assuming your using composer to manage plugins etc.

Unforutnately we can't just yet, the only option would be to remove the platform requirement entirely, but moving it to match the readme was leading to dev dependency issues on some of our tooling.

We are planning to move the plugins requirements to 7.4 in the near future... BUT... our tooling requires PHP 7.4 now.

The goal is within the next 2 major versions to be fully to PHP v7.4+ & WP v6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants