Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button text missing when popups are imported #964

Open
marklchaves opened this issue Jun 1, 2021 · 1 comment
Open

Close button text missing when popups are imported #964

marklchaves opened this issue Jun 1, 2021 · 1 comment
Labels

Comments

@marklchaves
Copy link
Contributor

Describe the bug

The text for the close button is missing after a popup is imported using the WordPress export and import tools.

Site information

Popup Maker version: 1.16.1

WordPress version: 5.7.2

PHP version: 7.3.5

Expected behavior

After a popup is imported, the text for the close button should be the same as the popup that was exported.

Current behavior

The text for the close button is missing. There's no close button text.

Steps to reproduce

  1. Export your popups (Tools > Export)
  2. Import your popups to another WordPress site (Tools > Import).
  3. Launch your popups.
  4. Verify the close button text is missing (not there).

Errors

None.

Additional context

See screen capture.

Popup_Focus_–_caught_my_eye_dev_v

@danieliser
Copy link
Member

Hmm, so there are 2 things here to look at, the default close button text is set from the popup theme used by that popup.

Then a popup can have its own override value.

My guess is that the export with null value is being set to "" on export and thus on import is using the empty string to override the popup theme.

Might be worth modifying the output during the export to set that value to the one that should be rendered, so in this case maybe the export instead of null or '' would use the value from the current theme used by that popup instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants