CLI v2.0.0 Release Discussion

[Pradumnasaraf]

The major parts of CLI are already done. This discussion aims to polish things up before BREAKING CHANGES release v2.0.0

[Pradumnasaraf]

Minor things need to fix. If you find something feels free to add them below.

1. If a person doesn't update the profile. The final message should be something like - "Nothing got updated" instead successful message.

2. In the update profile, we need to add a little clear message about which testimonials it's updating, the usernames, or the person given

3. When we delete all the elements by the update option. It should remove the empty key

4. There are some keys that are optional and but we ask the user to enter the value. For eg, color and links in the milestone. So either we need to ask if they wan't to add them (choice) or remove the empty keys somehow at the end before writing to the file. Hope you got what I am trying to explain.

[Pradumnasaraf]

Hey, @Ananya2001-an,

I have shared a whole new discussion because #23 has become a lot messed up. You can share your thoughts here

[Ananya2001-an]

Yeah sure

[Ananya2001-an]

I think the above mentioned problems are the only ones that are to be dealt with
1, 2, 3 will be done easily but for the 4th one I think we will have to think before doing anything. For the 4th point we can create another prompt asking the user if they want to add it or not and then take input. Accordingly we will have to make those changes in delete and update functions as well.

[Pradumnasaraf]

Great points. Thank you

[Pradumnasaraf]

I think you are missing an important message #30 (comment) 👀

[Pradumnasaraf]

Hey, @Ananya2001-an

I was looking at the optional keys things. One thing I noticed is that asking users if they want to enter will add more complexity. I think we can follow something we did in the create profile one. (See the last if statement in the image). We can add if statements for optional things

By this, I mean that we can ask questions every time, but in brackets, we can say (This is optional Q .press enter to skip this). And if statement will only add to JSON if something is there.

This will also will safeguard for future as well. What do you think?

[Pradumnasaraf]

Yeah I guess leave it for now. Because for the groups I have an idea of using select option so that for each new link user doesn't have to write the group name again and again but just choose from the ones already created but I will have to think before doing it.

Yes, You just read my mind.

We have an even better option. Enquirer has a multiple-choice option, so we can do something like when the user created all the links, we can ask them to select all the links they want to bunch and at the end with another chain prompt give it a name

[Pradumnasaraf]

I think we just have to fix the third minor change that we have listed earlier. That's important to do for now.

Oh yes. Would you like to fix that?

[Ananya2001-an]

Yeah I guess leave it for now. Because for the groups I have an idea of using select option so that for each new link user doesn't have to write the group name again and again but just choose from the ones already created but I will have to think before doing it.

Yes, You just read my mind.

We have an even better option. Enquirer has a multiple-choice option, so we can do something like when the user created all the links, we can ask them to select all the links they want to bunch and at the end with another chain prompt give it a name

Great we can do that later then

[Ananya2001-an]

I think we just have to fix the third minor change that we have listed earlier. That's important to do for now.

Oh yes. Would you like to fix that?

Yeah sure i will do it.

[Pradumnasaraf]

Thank you. Also, If you want to enhance anything else feel free to include that in the PR.

[Pradumnasaraf]

Hey, I find something cool. We can add this to icons in future

https://github.com/enquirer/enquirer#autocomplete-prompt

[Ananya2001-an]

Hey, I find something cool. We can add this to icons in future

https://github.com/enquirer/enquirer#autocomplete-prompt

Yeah this looks cool. We can actually do a lot of customization stuff in the future to make it look a bit more organized and eye catchy I guess that will be fun

[Pradumnasaraf]

Awesome 100%

[Pradumnasaraf]

Notes for the release

• Halt the Releases Action - Done
• Prepare a draft - Done
• Create a PR for below
  • Remove test data - Done
  • Bump up the version manually in package.json and package-lock.json Done
  • Update CHANGELOG.md
  • Update README with the new GIF, steps, feature, and maintainer's name (Ananya)

Post Release

• Update the dependency of linkfree-cli in LinkFree

[Pradumnasaraf]

Again congrats @Ananya2001-an 🎉

[Pradumnasaraf]

Also, I think I will lock both the discussion (It will not get deleted) and just a general discussion.

[Ananya2001-an]

Also, I think I will lock both the discussion (It will not delete) and just a general discussion.

sure

[Pradumnasaraf]

Also, I think I will lock both the discussion (It will not delete) and just a general discussion.

sure

Aweome, I will do that. But you are maintainers you can still comment :)

[Ananya2001-an]

Also, I think I will lock both the discussion (It will not delete) and just a general discussion.

sure

Aweome, I will do that. But you are maintainers you can still comment :)

perks of being a maintainer ;)

[Pradumnasaraf]

perks of being a maintainer ;)

Hehe 💯