Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month showing as integer, not string, in selector #180

Open
RowanG1 opened this issue Jul 10, 2023 · 1 comment
Open

Month showing as integer, not string, in selector #180

RowanG1 opened this issue Jul 10, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@RowanG1
Copy link

RowanG1 commented Jul 10, 2023

Describe the bug
Despite setting locale to various values, like Locale.US, the selector month shows as a integer, not as a string.

To Reproduce
Steps to reproduce the behaviour (including any applicable code):

  1. Launch date picker, try to look for a month like "march" to select.

Expected behaviour
The month is shown as a string eg March.

Screenshots

dialog_month_1

Please complete the following information about your device:

  • Name: Samsubg S23 Ultra
  • Android Version: Android 13

Additional context
Add any other context about the problem here.

@RowanG1 RowanG1 added the bug Something isn't working label Jul 10, 2023
@RowanG1
Copy link
Author

RowanG1 commented Jul 12, 2023

Looking at the code, this line appears to be the issue:

https://github.com/vanpra/compose-material-dialogs/blob/8c45e66933d50a782a91c85e766000ecdd6d649f/datetime/src/main/java/com/vanpra/composematerialdialogs/datetime/util/Extensions.kt#L32

instead of:
this.getDisplayName(java.time.format.TextStyle.FULL, locale)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants